apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.11k stars 1.11k forks source link

Fix Ctrl+Enter command on `Start Instance` dialog #9743

Closed lucas-a-martins closed 1 week ago

lucas-a-martins commented 2 months ago

Description

This PR fixes the bug presented in the issue #9668, where the Start instance dialog in the UI does not respond to the Ctrl+Enter command.

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

I tested by using the Ctrl+Enter command when starting a VM in the instance list view and the VM details view. Worked as intended in both cases.

JoaoJandre commented 1 month ago

@lucas-a-martins could you add a proper PR description and test description?

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.78%. Comparing base (21d107c) to head (3e714d9). Report is 60 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9743 +/- ## ============================================ - Coverage 15.81% 15.78% -0.03% - Complexity 12551 12552 +1 ============================================ Files 5625 5625 Lines 491921 491963 +42 Branches 60594 63690 +3096 ============================================ - Hits 77802 77668 -134 - Misses 405802 405835 +33 - Partials 8317 8460 +143 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9743/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9743/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.03% <ø> (-0.45%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9743/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.60% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lucas-a-martins commented 1 month ago

@lucas-a-martins could you add a proper PR description and test description?

Done!

DaanHoogland commented 2 weeks ago

@blueorangutan ui