check tags while fetching storage pool for importing vm

vishesh92 commented 1 month ago

Description

This PR fixes https://github.com/apache/cloudstack/issues/9670

Will continue on this after https://github.com/apache/cloudstack/pull/9787.

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[x] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[x] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

vishesh92 commented 1 month ago

@blueorangutan package

blueorangutan commented 1 month ago

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 15.08%. Comparing base (e666dca) to head (61ebded).

Files with missing lines	Patch %	Lines
.../apache/cloudstack/vm/UnmanagedVMsManagerImpl.java	14.28%	2 Missing and 4 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## 4.19 #9764 +/- ## ============================================ - Coverage 15.08% 15.08% -0.01% Complexity 11184 11184 ============================================ Files 5402 5402 Lines 473170 473172 +2 Branches 59687 59455 -232 ============================================ Hits 71371 71371 Misses 393859 393859 - Partials 7940 7942 +2 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9764/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9764/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.29% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9764/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `15.80% <14.28%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blueorangutan commented 1 month ago

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 11268

sureshanaparti commented 1 month ago

@vishesh92 check/fix unit tests.

vishesh92 commented 1 month ago

@blueorangutan package

blueorangutan commented 1 month ago

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 1 month ago

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11276

vishesh92 commented 1 month ago

@blueorangutan test

blueorangutan commented 1 month ago

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented 1 month ago

[SF] Trillian test result (tid-11613) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51907 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9764-t11613-kvm-ol8.zip Smoke tests completed. 130 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	`Error`	134.42	test_vm_life_cycle.py
test_01_secure_vm_migration	`Error`	134.42	test_vm_life_cycle.py
test_05_vmschedule_test_e2e	`Failure`	362.27	test_vm_schedule.py
test_05_rvpc_multi_tiers	`Failure`	482.80	test_vpc_redundant.py
test_05_rvpc_multi_tiers	`Error`	482.81	test_vpc_redundant.py

vishesh92 commented 1 month ago

CLGTM. Could you describe your tests @vishesh92 ?

I am still testing it. Let me make this PR as a draft for now.

vishesh92 commented 1 month ago

There are some issues. I will continue on this after https://github.com/apache/cloudstack/pull/9787.

apache / cloudstack