UI improvements - Githubissues

Description

This PR does multiple UI improvements

Autofill vCenter host, datacenter and credentials while adding cluster using the zone wide value from vmware_data_center table
Show Usage settings as a different pane in global settings
Option to attach the volume to an instance during volume create.
Show mgmt server's service ip in the details tab of Infrastructure -> Management server.
Don't display create volume snapshot button in the Instance tab for KVM, if the instance is running and "kvm.snapshot.enabled" is false. (Also contains some code cleanup in storage.js)
The name Recurring snapshots is used everywhere except for one place where 'Scheduled' snapshots is used in the Recurring Snapshots form. Change it to Recurring Snapshots.
Reorder the Hypervisor list shown everywhere in order of popularity.

Items 1,3,4,5,6 are UI only changes, and can be tested with just the UI.

Doc PR : https://github.com/apache/cloudstack-documentation/pull/448

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[ ] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[x] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 4.03%. Comparing base (f7b7339) to head (e289502).

:exclamation: There is a different number of reports uploaded between BASE (f7b7339) and HEAD (e289502). Click for more details.

HEAD has 1 upload less than BASE
| Flag | BASE (f7b7339) | HEAD (e289502) | |------|------|------| |unittests|1|0|

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9773 +/- ## ============================================ - Coverage 15.80% 4.03% -11.77% ============================================ Files 5627 392 -5235 Lines 492294 32212 -460082 Branches 62198 5687 -56511 ============================================ - Hits 77824 1301 -76523 + Misses 405946 30763 -375183 + Partials 8524 148 -8376 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9773/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.03% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9773/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@blueorangutan package

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11289

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9773 (QA-JID-461)

@abh1sar , given that there are DB changes as well, I don't think UI tests will be enought, do you?

@abh1sar , given that there are DB changes as well, I don't think UI tests will be enought, do you?

@DaanHoogland You are right. These items contain db changes for which full testing will be required

Show Usage settings as a different pane in global settings
Reorder the Hypervisor list shown everywhere in order of popularity.

For the rest of the items, ui testing is enough.

P.S I have added db changes to schema-41900to42000 for now. Will move it to schema-42000-42010 once CloudStack version changes to 4.20.1. Will keep this PR in draft until then.

[SF] Trillian Build Failed (tid-11647)

@blueorangutan package

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11315

@abh1sar a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-11662) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 49908 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9773-t11662-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

@blueorangutan package

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11407

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@blueorangutan package

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11465

@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan package

@borisstoyanov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11467

@borisstoyanov a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

UI build failed: :heavy_multiplication_x: (SL-JID-472)

@abh1sar can you check the outstanding comments please

@borisstoyanov This needs database upgrade path change after 4.20.1 branch is created. So, Keeping in draft until then.

apache / cloudstack

UI improvements #9773

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Codecov Report