apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.11k stars 1.11k forks source link

packaging: add libvirt-daemon-driver-storage-rbd as cloudstack-agent dependency #9799

Closed weizhouapache closed 1 month ago

weizhouapache commented 1 month ago

Description

This PR fixes #9797

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

andrijapanicsb commented 1 month ago

@weizhouapache this was spoted only for Ubuntu 22.04+, not sure if EL8 are affected

weizhouapache commented 1 month ago

@weizhouapache this was spoted only for Ubuntu 22.04+, not sure if EL8 are affected

@andrijapanicsb the package name is the same on ubuntu 22/24 and el8/9

it is a known issue (for me yes)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.78%. Comparing base (46201ee) to head (7bc27d2). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9799 +/- ## =========================================== Coverage 15.78% 15.78% Complexity 12565 12565 =========================================== Files 5627 5627 Lines 492260 492260 Branches 63882 61404 -2478 =========================================== Hits 77710 77710 Misses 406076 406076 Partials 8474 8474 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9799/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9799/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.04% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9799/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.60% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rohityadavcloud commented 1 month ago

@weizhouapache is this considered critical for 4.20 release? cc @JoaoJandre

@blueorangutan package

blueorangutan commented 1 month ago

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 1 month ago

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11357

weizhouapache commented 1 month ago

@blueorangutan test ol9 kvm-ol9

blueorangutan commented 1 month ago

@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + kvm-ol9) has been kicked to run smoke tests

weizhouapache commented 1 month ago

@blueorangutan test ol8 kvm-ol8

blueorangutan commented 1 month ago

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented 1 month ago

[SF] Trillian Build Failed (tid-11668)

weizhouapache commented 1 month ago

kicked off tests on

  • ol8
  • ol9
  • ubuntu24
  • debian12

let's wait

blueorangutan commented 1 month ago

[SF] Trillian test result (tid-11669) Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12 Total time taken: 51942 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11669-kvm-debian12.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
blueorangutan commented 1 month ago

[SF] Trillian test result (tid-11670) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 54498 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11670-kvm-ol8.zip Smoke tests completed. 141 look OK, 0 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
blueorangutan commented 1 month ago

[SF] Trillian test result (tid-11673) Environment: kvm-ubuntu24 (x2), Advanced Networking with Mgmt server u24 Total time taken: 53141 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11673-kvm-ubuntu24.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_hostha_enable_ha_when_host_disabled Error 4.00 test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance Error 302.04 test_hostha_kvm.py
blueorangutan commented 1 month ago

[SF] Trillian test result (tid-11667) Environment: kvm-ol9 (x2), Advanced Networking with Mgmt server ol9 Total time taken: 64695 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9799-t11667-kvm-ol9.zip Smoke tests completed. 140 look OK, 1 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Failure 272.88 test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL Error 272.90 test_vpc_redundant.py
weizhouapache commented 1 month ago

this is ready for review

the smoke test results look fine

rohityadavcloud commented 1 month ago

LGTM, tests & review LGTM. Only affects deb packaging that too installation of a required dependency on Ubuntu.