apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.1k stars 1.11k forks source link

ui: improve metrics api use in list views #9825

Open shwstppr opened 1 month ago

shwstppr commented 1 month ago

Description

In UI for the list views it is regular API view by default and Metrics API response may not be needed. Metrics APIs will take more time to return response so this PR tries to improve the behaviour and enables calling regular API without metrics when metrics toggle is not enabled.

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

https://github.com/user-attachments/assets/1806a6e5-a9d1-4a93-962f-ac0e41711c9f

How Has This Been Tested?

How did you try to break this feature and the system with this change?

shwstppr commented 1 month ago

@blueorangutan ui

blueorangutan commented 1 month ago

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented 1 month ago

UI build failed: :heavy_multiplication_x: (SL-JID-464)

shwstppr commented 1 month ago

@blueorangutan ui

blueorangutan commented 1 month ago

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.78%. Comparing base (20901c7) to head (6af86a7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9825 +/- ## =========================================== Coverage 15.78% 15.78% - Complexity 12564 12565 +1 =========================================== Files 5627 5627 Lines 492266 492267 +1 Branches 63860 61319 -2541 =========================================== + Hits 77707 77709 +2 + Misses 406084 406083 -1 Partials 8475 8475 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9825/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9825/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.04% <ø> (+<0.01%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9825/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.60% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

blueorangutan commented 1 month ago

UI build failed: :heavy_multiplication_x: (SL-JID-465)

DaanHoogland commented 3 weeks ago

@blueorangutan ui

blueorangutan commented 3 weeks ago

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented 3 weeks ago

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9825 (QA-JID-476)