Support for Management Server Maintenance

sureshanaparti commented 4 weeks ago

Description

This PR adds support for Management Server Maintenance. More details below.

New APIs: prepareForMaintenance and cancelMaintenance, with required parameter - managementserverid.
New management server states for maintenance: PreparingForMaintenance, Maintenance.
listHosts API with optional parameter – managementserverid, to list the hosts connected to the management server.
Support management server maintenance when more than one active management servers available.
Triggers transfer agents to other available management servers for maintenance, new agent command MigrateAgentConnectionCommand to initiate transfer of indirect agents.
New global config 'management.server.maintenance.timeout', to set the timeout (in mins) for the management server maintenance window, default: 60 mins.
UI changes: Prepare and Cancel Maintenance in Management Server section, Connected Agents tab, New fields for hosts and management servers.

This also updates the shutdown plugin introduced here: https://github.com/apache/cloudstack/pull/6755, to maintenance plugin (as common plugin for MS maintenance and shutdown operations).

Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[x] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI
[ ] test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

[x] Major
[ ] Minor

Bug Severity

[ ] BLOCKER
[ ] Critical
[ ] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually tested prepare and cancel management server maintenance operations.

How did you try to break this feature and the system with this change?

sureshanaparti commented 4 weeks ago

@blueorangutan package

blueorangutan commented 4 weeks ago

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 9.29809% with 995 lines in your changes missing coverage. Please review.

Project coverage is 15.79%. Comparing base (a82a242) to head (023ca4c). Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...enance/ManagementServerMaintenanceManagerImpl.java	14.48%	298 Missing and 3 partials :warning:
...cloud/agent/manager/ClusteredAgentManagerImpl.java	0.00%	121 Missing :warning:
...loudstack/agent/lb/IndirectAgentLBServiceImpl.java	12.24%	84 Missing and 2 partials :warning:
agent/src/main/java/com/cloud/agent/Agent.java	0.00%	64 Missing :warning:
...java/com/cloud/agent/manager/AgentManagerImpl.java	6.45%	58 Missing :warning:
.../response/ManagementServerMaintenanceResponse.java	0.00%	35 Missing :warning:
...cloud/agent/api/MigrateAgentConnectionCommand.java	0.00%	24 Missing :warning:
...d/cluster/dao/ManagementServerHostPeerDaoImpl.java	0.00%	22 Missing :warning:
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java	36.66%	19 Missing :warning:
...oudstack/api/command/PrepareForMaintenanceCmd.java	0.00%	19 Missing :warning:
... and 41 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #9854 +/- ## ============================================ - Coverage 15.80% 15.79% -0.02% - Complexity 12585 12591 +6 ============================================ Files 5627 5635 +8 Lines 492341 493184 +843 Branches 59693 59793 +100 ============================================ + Hits 77827 77890 +63 - Misses 405990 406769 +779 - Partials 8524 8525 +1 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9854/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.04% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9854/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.61% <9.29%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

Flaky Tests Detection - Detect and resolve failed and flaky tests
JS Bundle Analysis - Avoid shipping oversized bundles

blueorangutan commented 4 weeks ago

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11437

sureshanaparti commented 4 weeks ago

@blueorangutan test

blueorangutan commented 4 weeks ago

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan commented 4 weeks ago

[SF] Trillian test result (tid-11701) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 52486 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9854-t11701-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_prepare_and_cancel_maintenance	`Error`	0.05	test_ms_maintenance_and_safe_shutdown.py
test_02_unsecure_vm_migration	`Error`	449.14	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	`Error`	382.76	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	`Error`	378.56	test_vm_life_cycle.py

sureshanaparti commented 2 weeks ago

@blueorangutan package