apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.11k stars 1.11k forks source link

UI: Add UI support for `forvpc` and `guestiptype` parameters of the `listNetworkOfferings` API #9947

Open bernardodemarco opened 6 days ago

bernardodemarco commented 6 days ago

Description

Currently, the listNetworkOfferings API supports the forvpc and guestiptype parameters (see API docs). The first is used to filter network offerings that can only be used for creating VPC tiers; the second allows filtering by guest network type (available options are: Isolated, Shared and L2).

This PR adds support to these parameters in the UI. The forvpc filter has been added as a normal filter (declared in the filters property of the network offerings section's object) and the guestiptype as a search filter (declared in the searchFilters property).

Furthermore, this PR also fixes a bug that caused duplicate options to appear in search filter lists.


Fixes #9924

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

image

image

How Has This Been Tested?

forvpc filter tests

guestiptype filter tests

Duplicate options in search filter lists

Before ![image](https://github.com/user-attachments/assets/c0a4fa4e-ad0c-4506-94a4-22f64db93467)
After ![image](https://github.com/user-attachments/assets/36d36828-d730-498a-aa51-3d017934ab02)
bernardodemarco commented 6 days ago

@blueorangutan ui

blueorangutan commented 6 days ago

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.80%. Comparing base (8a2c0f3) to head (75c6305).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9947 +/- ## ============================================ - Coverage 15.80% 15.80% -0.01% - Complexity 12585 12586 +1 ============================================ Files 5627 5627 Lines 492343 492350 +7 Branches 59694 59694 ============================================ Hits 77828 77828 - Misses 405992 405999 +7 Partials 8523 8523 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9947/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9947/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.04% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9947/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.63% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

blueorangutan commented 6 days ago

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9947 (QA-JID-481)