apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.11k stars 1.11k forks source link

virtual router: Add route-maps to BGP peers for Routed Mode #9964

Open wido opened 3 days ago

wido commented 3 days ago

It is best practice, and mandatory in newer version of FRR, that route-maps should be applied to BGP peers. This is to prevent that mistakes can propogate through a network and cause outages.

This change changes the route-maps where the VR will only accept IPv4 and IPv4 default gateways (0.0.0.0/0 and ::/0) to be sent by the upstream router to the VR.

The other way around this change makes sure that FRR will not allow announcing anything else than the locally defined subnets to the upstream BGP router.

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.80%. Comparing base (8a2c0f3) to head (14e27de).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #9964 +/- ## ============================================ - Coverage 15.80% 15.80% -0.01% Complexity 12585 12585 ============================================ Files 5627 5627 Lines 492343 492343 Branches 59694 59694 ============================================ - Hits 77828 77825 -3 - Misses 405992 405994 +2 - Partials 8523 8524 +1 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9964/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.04% <ø> (ø)` | | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9964/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.62% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

weizhouapache commented 1 day ago

thanks @wido !

weizhouapache commented 1 day ago

@blueorangutan package

blueorangutan commented 1 day ago

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan commented 1 day ago

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11599

weizhouapache commented 1 day ago

@blueorangutan test ubuntu24 kvm-ubuntu24

blueorangutan commented 1 day ago

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + kvm-ubuntu24) has been kicked to run smoke tests

blueorangutan commented 14 hours ago

[SF] Trillian test result (tid-11794) Environment: kvm-ubuntu24 (x2), Advanced Networking with Mgmt server u24 Total time taken: 54170 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9964-t11794-kvm-ubuntu24.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_oobm_background_powerstate_sync Failure 20.83 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Error 38.04 test_outofbandmanagement.py
test_oobm_issue_power_cycle Error 19.81 test_outofbandmanagement.py
test_oobm_issue_power_off Error 19.77 test_outofbandmanagement.py
test_oobm_issue_power_on Error 19.80 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 19.84 test_outofbandmanagement.py
test_oobm_issue_power_soft Error 19.80 test_outofbandmanagement.py
test_oobm_issue_power_status Error 18.79 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Failure 28.12 test_outofbandmanagement.py
test_oobm_zchange_password Error 7.45 test_outofbandmanagement.py
test_hostha_kvm_host_degraded Error 12.65 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 10.14 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 10.41 test_hostha_kvm.py