apache / cloudstack

Apache CloudStack is an opensource Infrastructure as a Service (IaaS) cloud computing platform
https://cloudstack.apache.org/
Apache License 2.0
2.11k stars 1.11k forks source link

Displaying info of the labels from form CreateSSHKeyPair #9970

Closed LayonRibeiro closed 1 day ago

LayonRibeiro commented 4 days ago

Description

This PR aims to display the label hints in the CreateSSHKeyPair form, which are currently not shown, negatively impacting the user experience.

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

Before

before

After

after

How Has This Been Tested?

The label hints were displayed in the form in question.
bernardodemarco commented 4 days ago

@blueorangutan ui

blueorangutan commented 4 days ago

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan commented 4 days ago

UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9970 (QA-JID-485)

codecov[bot] commented 2 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 15.80%. Comparing base (f7b7339) to head (cc2e1d8). Report is 16 commits behind head on 4.20.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 4.20 #9970 +/- ## ============================================ - Coverage 15.80% 15.80% -0.01% Complexity 12586 12586 ============================================ Files 5627 5627 Lines 492294 492344 +50 Branches 62198 59694 -2504 ============================================ + Hits 77824 77828 +4 - Misses 405946 405993 +47 + Partials 8524 8523 -1 ``` | [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/9970/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/9970/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.04% <ø> (-0.01%)` | :arrow_down: | | [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/9970/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `16.63% <ø> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.