search

apache / cordova-android

Apache Cordova Android
https://cordova.apache.org/
Apache License 2.0
3.65k stars 1.54k forks source link

Icon #1088

Open phyr0s opened 3 years ago

phyr0s commented 3 years ago

Bug Report

Problem

In master version the icon of the app is not showing.

What is expected to happen?

Icon of app not showing (shows cordova default icon)

What does actually happen?

Show icon declared in the config.xml (example)

    <icon qualifier="mdpi" src="resources/android/icon/drawable-mdpi-icon.png" />
    <icon qualifier="hdpi" src="resources/android/icon/drawable-hdpi-icon.png" />
    <icon qualifier="xhdpi" src="resources/android/icon/drawable-xhdpi-icon.png" />
    <icon qualifier="xxhdpi" src="resources/android/icon/drawable-xxhdpi-icon.png" />
    <icon qualifier="xxxhdpi" src="resources/android/icon/drawable-xxxhdpi-icon.png" />

Information

Just run any application and icon doesn't show

Command or Code

cordova run android

Environment, Platform, Device

All envirnoment Platform android Device android

Version information

cordova cli 10 cordova-android --> https://github.com/apache/cordova-android.git --> master version (nightly)

Checklist

  • [ x] I searched for existing GitHub issues
  • [x ] I updated all Cordova tooling to most recent version
  • [ x] I included all the necessary information above
breautek commented 3 years ago

Please share your config.xml

phyr0s commented 3 years ago 
<?xml version='1.0' encoding='utf-8'?>
<widget android-versionCode="14" id="com.app.myapp" ios-CFBundleVersion="1.0.14" version="1.0.14" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
    <name>Myapp</name>
    <description>An awesome Ionic/Cordova app.</description>
    <content src="index.html" />
    <access origin="*" />
    <allow-intent href="http://*/*" />
    <allow-intent href="https://*/*" />
    <allow-intent href="tel:*" />
    <allow-intent href="sms:*" />
    <allow-intent href="mailto:*" />
    <allow-intent href="geo:*" />
    <access launch-external="yes" origin="whatsapp://*" />
    <feature name="CDVWKWebViewEngine">
        <param name="ios-package" value="CDVWKWebViewEngine" />
    </feature>
    <preference name="Orientation" value="portrait" />
    <preference name="CordovaWebViewEngine" value="CDVWKWebViewEngine" />
    <preference name="ScrollEnabled" value="false" />
    <preference name="android-minSdkVersion" value="22" />
    <preference name="android-compileSdkVersion" value="29" />
    <preference name="android-targetSdkVersion" value="29" />
    <preference name="BackupWebStorage" value="none" />
    <preference name="AutoHideSplashScreen" value="false" />
    <preference name="SplashShowOnlyFirstTime" value="true" />
    <preference name="SplashMaintainAspectRatio" value="true" />
    <preference name="FadeSplashScreenDuration" value="300" />
    <preference name="SplashScreen" value="screen" />
    <preference name="ShowSplashScreenSpinner" value="false" />
    <platform name="android">
        <hook src="hooks/copy_android_notification_icons.js" type="after_prepare" />
        <edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application" xmlns:android="http://schemas.android.com/apk/res/android">
            <application android:networkSecurityConfig="@xml/network_security_config" />
            <application android:requestLegacyExternalStorage="true" android:usesCleartextTraffic="true" />
        </edit-config>
        <resource-file src="resources/android/xml/network_security_config.xml" target="app/src/main/res/xml/network_security_config.xml" />
        <allow-intent href="market:*" />
        <icon density="ldpi" src="resources/android/icon/drawable-ldpi-icon.png" />
        <icon density="mdpi" src="resources/android/icon/drawable-mdpi-icon.png" />
        <icon density="hdpi" src="resources/android/icon/drawable-hdpi-icon.png" />
        <icon density="xhdpi" src="resources/android/icon/drawable-xhdpi-icon.png" />
        <icon density="xxhdpi" src="resources/android/icon/drawable-xxhdpi-icon.png" />
        <icon density="xxxhdpi" src="resources/android/icon/drawable-xxxhdpi-icon.png" />
        <splash density="land-ldpi" src="resources/android/splash/drawable-land-ldpi-screen.png" />
        <splash density="land-mdpi" src="resources/android/splash/drawable-land-mdpi-screen.png" />
        <splash density="land-hdpi" src="resources/android/splash/drawable-land-hdpi-screen.png" />
        <splash density="land-xhdpi" src="resources/android/splash/drawable-land-xhdpi-screen.png" />
        <splash density="land-xxhdpi" src="resources/android/splash/drawable-land-xxhdpi-screen.png" />
        <splash density="land-xxxhdpi" src="resources/android/splash/drawable-land-xxxhdpi-screen.png" />
        <splash density="port-ldpi" src="resources/android/splash/drawable-port-ldpi-screen.png" />
        <splash density="port-mdpi" src="resources/android/splash/drawable-port-mdpi-screen.png" />
        <splash density="port-hdpi" src="resources/android/splash/drawable-port-hdpi-screen.png" />
        <splash density="port-xhdpi" src="resources/android/splash/drawable-port-xhdpi-screen.png" />
        <splash density="port-xxhdpi" src="resources/android/splash/drawable-port-xxhdpi-screen.png" />
        <splash density="port-xxxhdpi" src="resources/android/splash/drawable-port-xxxhdpi-screen.png" />
    </platform>
    <platform name="ios">
        <config-file parent="UIUserInterfaceStyle" platform="ios" target="*-Info.plist">
            <string>Light</string>
        </config-file>
        <allow-intent href="itms:*" />
        <allow-intent href="itms-apps:*" />
        <icon height="57" src="resources/ios/icon/icon.png" width="57" />
        <icon height="114" src="resources/ios/icon/icon@2x.png" width="114" />
        <icon height="29" src="resources/ios/icon/icon-small.png" width="29" />
        <icon height="58" src="resources/ios/icon/icon-small@2x.png" width="58" />
        <icon height="87" src="resources/ios/icon/icon-small@3x.png" width="87" />
        <icon height="20" src="resources/ios/icon/icon-20.png" width="20" />
        <icon height="40" src="resources/ios/icon/icon-20@2x.png" width="40" />
        <icon height="60" src="resources/ios/icon/icon-20@3x.png" width="60" />
        <icon height="48" src="resources/ios/icon/icon-24@2x.png" width="48" />
        <icon height="55" src="resources/ios/icon/icon-27.5@2x.png" width="55" />
        <icon height="29" src="resources/ios/icon/icon-29.png" width="29" />
        <icon height="58" src="resources/ios/icon/icon-29@2x.png" width="58" />
        <icon height="87" src="resources/ios/icon/icon-29@3x.png" width="87" />
        <icon height="40" src="resources/ios/icon/icon-40.png" width="40" />
        <icon height="80" src="resources/ios/icon/icon-40@2x.png" width="80" />
        <icon height="120" src="resources/ios/icon/icon-40@3x.png" width="120" />
        <icon height="88" src="resources/ios/icon/icon-44@2x.png" width="88" />
        <icon height="50" src="resources/ios/icon/icon-50.png" width="50" />
        <icon height="100" src="resources/ios/icon/icon-50@2x.png" width="100" />
        <icon height="60" src="resources/ios/icon/icon-60.png" width="60" />
        <icon height="120" src="resources/ios/icon/icon-60@2x.png" width="120" />
        <icon height="180" src="resources/ios/icon/icon-60@3x.png" width="180" />
        <icon height="72" src="resources/ios/icon/icon-72.png" width="72" />
        <icon height="144" src="resources/ios/icon/icon-72@2x.png" width="144" />
        <icon height="76" src="resources/ios/icon/icon-76.png" width="76" />
        <icon height="152" src="resources/ios/icon/icon-76@2x.png" width="152" />
        <icon height="167" src="resources/ios/icon/icon-83.5@2x.png" width="167" />
        <icon height="172" src="resources/ios/icon/icon-86@2x.png" width="172" />
        <icon height="196" src="resources/ios/icon/icon-98@2x.png" width="196" />
        <icon height="1024" src="resources/ios/icon/icon-1024.jpg" width="1024" />
        <splash height="480" src="resources/ios/splash/Default~iphone.png" width="320" />
        <splash height="960" src="resources/ios/splash/Default@2x~iphone.png" width="640" />
        <splash height="1024" src="resources/ios/splash/Default-Portrait~ipad.png" width="768" />
        <splash height="768" src="resources/ios/splash/Default-Landscape~ipad.png" width="1024" />
        <splash height="1125" src="resources/ios/splash/Default-Landscape-2436h.png" width="2436" />
        <splash height="1242" src="resources/ios/splash/Default-Landscape-736h.png" width="2208" />
        <splash height="2048" src="resources/ios/splash/Default-Portrait@2x~ipad.png" width="1536" />
        <splash height="1536" src="resources/ios/splash/Default-Landscape@2x~ipad.png" width="2048" />
        <splash height="2732" src="resources/ios/splash/Default-Portrait@~ipadpro.png" width="2048" />
        <splash height="2048" src="resources/ios/splash/Default-Landscape@~ipadpro.png" width="2732" />
        <splash height="1136" src="resources/ios/splash/Default-568h@2x~iphone.png" width="640" />
        <splash height="1334" src="resources/ios/splash/Default-667h.png" width="750" />
        <splash height="2208" src="resources/ios/splash/Default-736h.png" width="1242" />
        <splash height="2436" src="resources/ios/splash/Default-2436h.png" width="1125" />
        <splash height="2732" src="resources/ios/splash/Default@2x~universal~anyany.png" width="2732" />
        <icon height="216" src="resources/ios/icon/icon-108@2x.png" width="216" />
        <splash height="2688" src="resources/ios/splash/Default-2688h~iphone.png" width="1242" />
        <splash height="1242" src="resources/ios/splash/Default-Landscape-2688h~iphone.png" width="2688" />
        <splash height="1792" src="resources/ios/splash/Default-1792h~iphone.png" width="828" />
        <splash height="828" src="resources/ios/splash/Default-Landscape-1792h~iphone.png" width="1792" />
        <icon height="1024" src="resources/ios/icon/icon-1024.png" width="1024" />
    </platform>
</widget>
phyr0s commented 3 years ago

@breautek just add your custom icon and you will see the default cordova icon.

breautek commented 3 years ago

Is this the icon you are talking about (In the app list screen)?

Screenshot from 2020-10-07 20-10-42

phyr0s commented 3 years ago

@breautek yes, that icon and the other icon in the menu both.

phyr0s commented 3 years ago

In this commit works fine @breautek 565106fc1f840cb681905e6add8a44dce40dc984

dpogue commented 3 years ago

In this commit works fine @breautek 565106f

Looking at the commit since then, maybe this was introduced by the change to glob in https://github.com/apache/cordova-android/pull/1085?

phyr0s commented 3 years ago

@dpogue i think the same.

breautek commented 3 years ago

In this commit works fine @breautek 565106f

Looking at the commit since then, maybe this was introduced by the change to glob in #1085?

I'm trying to narrow it down to the specific commit right now.

breautek commented 3 years ago

~For me the icon shown in the screen above breaks on https://github.com/apache/cordova-android/pull/1084/commits/98a15f2f811d246799cad25878a246f7b79dac51 (introduced from https://github.com/apache/cordova-android/pull/1084) though I'm not really sure why that commit would cause this behaviour.~

Behaviour is being inconsistent...

ctaque commented 3 years ago

I'm having a similar issue. My icon is showing but is missing the background.

Cordova 10.0.0

Here is my config.xml 

    <?xml version='1.0' encoding='utf-8'?>
<widget id="boutique.lemoulerobertloyson" version="1.4.0" xmlns="http://www.w3.org/ns/widgets" xmlns:android="http://schemas.android.com/apk/res/android" xmlns:cdv="http://cordova.apache.org/ns/1.0">
    <name>Salle Robert Loyson</name>
    <description>
        L'application Salle Robert Loyson permet de réserver des billets de cinéma et spectacle
    </description>
    <author email="dev@cordova.apache.org" href="http://cordova.io">
        Apache Cordova Team
    </author>
    <content src="index.html" />
    <allow-navigation href="*" />
    <access origin="*" />
    <preference name="StatusBarOverlaysWebView" value="false" />
    <allow-intent href="http://*/*" />
    <allow-intent href="https://*/*" />
    <allow-intent href="tel:*" />
    <allow-intent href="sms:*" />
    <allow-intent href="mailto:*" />
    <allow-intent href="geo:*" />
    <platform name="android">
        <allow-intent href="market:*" />
        <icon density="ldpi" src="res/android/icon/ldpi.png" />
        <icon density="mdpi" src="res/android/icon/mdpi.png" />
        <icon density="hdpi" src="res/android/icon/hdpi.png" />
        <icon density="xhdpi" src="res/android/icon/xhdpi.png" />
        <icon density="xxhdpi" src="res/android/icon/xxhdpi.png" />
        <icon density="xxxhdpi" src="res/android/icon/xxxhdpi.png" />
        <resource-file src="res/android/mipmap-hdpi/ic_launcher.png" target="app/src/main/res/mipmap-hdpi/ic_launcher.png" />
        <resource-file src="res/android/mipmap-hdpi/ic_launcher_round.png" target="app/src/main/res/mipmap-hdpi/ic_launcher_round.png" />
        <resource-file src="res/android/mipmap-mdpi/ic_launcher.png" target="app/src/main/res/mipmap-mdpi/ic_launcher.png" />
        <resource-file src="res/android/mipmap-mdpi/ic_launcher_round.png" target="app/src/main/res/mipmap-mdpi/ic_launcher_round.png" />
        <resource-file src="res/android/mipmap-xhdpi/ic_launcher.png" target="app/src/main/res/mipmap-xhdpi/ic_launcher.png" />
        <resource-file src="res/android/mipmap-xhdpi/ic_launcher_round.png" target="app/src/main/res/mipmap-xhdpi/ic_launcher_round.png" />
        <resource-file src="res/android/mipmap-xxhdpi/ic_launcher.png" target="app/src/main/res/mipmap-xxhdpi/ic_launcher.png" />
        <resource-file src="res/android/mipmap-xxhdpi/ic_launcher_round.png" target="app/src/main/res/mipmap-xxhdpi/ic_launcher_round.png" />
        <resource-file src="res/android/mipmap-xxxhdpi/ic_launcher.png" target="app/src/main/res/mipmap-xxxhdpi/ic_launcher.png" />
        <resource-file src="res/android/mipmap-xxxhdpi/ic_launcher_round.png" target="app/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png" />
        <splash density="land-hdpi" src="res/android/screen/splash-land-hdpi.png" />
        <splash density="land-ldpi" src="res/android/screen/splash-land-ldpi.png" />
        <splash density="land-mdpi" src="res/android/screen/splash-land-mdpi.png" />
        <splash density="land-xhdpi" src="res/android/screen/splash-land-xhdpi.png" />
        <splash density="land-xxhdpi" src="res/android/screen/splash-land-xxhdpi.png" />
        <splash density="land-xxxhdpi" src="res/android/screen/splash-land-xxxhdpi.png" />
        <splash density="port-hdpi" src="res/android/screen/splash-port-hdpi.png" />
        <splash density="port-ldpi" src="res/android/screen/splash-port-ldpi.png" />
        <splash density="port-mdpi" src="res/android/screen/splash-port-mdpi.png" />
        <splash density="port-xhdpi" src="res/android/screen/splash-port-xhdpi.png" />
        <splash density="port-xxhdpi" src="res/android/screen/splash-port-xxhdpi.png" />
        <splash density="port-xxxhdpi" src="res/android/screen/splash-port-xxxhdpi.png" />
        <preference name="android-targetSdkVersion" value="29" />
    </platform>
    <platform name="ios">
        <allow-intent href="itms:*" />
        <allow-intent href="itms-apps:*" />
        <icon height="180" src="res/ios/icon/icon-60@3x.png" width="180" />
        <icon height="60" src="res/ios/icon/icon-60.png" width="60" />
        <icon height="120" src="res/ios/icon/icon-60@2x.png" width="120" />
        <icon height="76" src="res/ios/icon/icon-76.png" width="76" />
        <icon height="152" src="res/ios/icon/icon-76@2x.png" width="152" />
        <icon height="40" src="res/ios/icon/icon-40.png" width="40" />
        <icon height="80" src="res/ios/icon/icon-40@2x.png" width="80" />
        <icon height="57" src="res/ios/icon/icon.png" width="57" />
        <icon height="114" src="res/ios/icon/icon@2x.png" width="114" />
        <icon height="72" src="res/ios/icon/icon-72.png" width="72" />
        <icon height="144" src="res/ios/icon/icon-72@2x.png" width="144" />
        <icon height="29" src="res/ios/icon/icon-small.png" width="29" />
        <icon height="58" src="res/ios/icon/icon-small@2x.png" width="58" />
        <icon height="50" src="res/ios/icon/icon-50.png" width="50" />
        <icon height="100" src="res/ios/icon/icon-50@2x.png" width="100" />
        <icon height="167" src="res/ios/icon/icon-167.png" width="167" />
        <icon height="167" src="res/ios/icon/icon-83.5@2x.png" width="167" />
        <icon height="1024" src="res/ios/icon/icon-1024.png" width="1024" />
        <splash src="res/ios/screen/Default@2x~iphone~anyany.png" />
        <splash src="res/ios/screen/Default@2x~iphone~comany.png" />
        <splash src="res/ios/screen/Default@2x~iphone~comcom.png" />
        <splash src="res/ios/screen/Default@3x~iphone~anyany.png" />
        <splash src="res/ios/screen/Default@3x~iphone~anycom.png" />
        <splash src="res/ios/screen/Default@3x~iphone~comany.png" />
        <splash src="res/ios/screen/Default@2x~ipad~anyany.png" />
        <splash src="res/ios/screen/Default@2x~ipad~comany.png" />
    <preference name="WKWebViewOnly" value="true" />
        <preference name="ScrollEnabled" value="true" />
    </platform>
    <engine name="browser" spec="^6.0.0" />
    <plugin name="cordova-plugin-whitelist" spec="1" />
    <plugin name="cordova-plugin-splashscreen" spec="~5.0.3" />
    <plugin name="cordova-plugin-statusbar" spec="^2.4.3" />
    <plugin name="cordova-plugin-ionic-webview" spec="^5.0.0" />
</widget>
GusLAN commented 3 years ago

Same error here using master version