search

apache / cordova-browser

Apache Cordova
Apache License 2.0
170 stars 85 forks source link

Switch from adm-zip to archiver. #10

Closed arlaneenalra closed 9 years ago

arlaneenalra commented 9 years ago

See: https://github.com/cthackers/adm-zip/issues/71

I ran into the above listed issue while attempting to package a Cordova application. In particular most of my images would extract as 0 byte files. Switching adm-zip out with archiver appears to fix the issue.

amikula commented 8 years ago

Why was this closed? cordova-browser's zip file generator still corrupts files. As far as I can tell, it hasn't been fixed anywhere, including in adm-zip.

josergcatmisatravelcom commented 8 years ago

Yeah! Why was this closed? just checked in Mac and in Windows and the same files are packed corrupted

josergcatmisatravelcom commented 8 years ago

Actually the new version is not visible through "cordova platform"

....>cordova platform add firefoxos@3.7 Error: Failed to fetch platform firefoxos@3.7 Probably this is either a connection problem, or platform spec is incorrect. Check your connection and platform name/version/URL. Error: No compatible version found: cordova-firefoxos@'>=3.7.0 <3.8.0' Valid install targets: ["3.5.0","3.6.0","3.6.0-dev","3.6.1","3.6.3"]

josergcatmisatravelcom commented 8 years ago

I had to patch my project to use the latest version. Remove the platform with "cordova platform remove firefoxos", then add it back with "cordova platform add firefoxos@https://github.com/apache/cordova-firefoxos.git". Reference https://cordova.apache.org/docs/en/latest/platform_plugin_versioning_ref/index.html

TimBarham commented 8 years ago

@amikula - this PR was closed by a commit made to cordova-firefoxos, which was probably done by mistake.

But regarding this problem specifically: since it was last released, cordova-browser has been updated to use the cordova-serve module, which in turn uses ExpressJS for things including handling compression. So this PR is out-of-date, and likely the problem will go away when we do another cordova-browser release (which I will kick off the process for).

In the meantime, you could try the latest changes to cordova-browser (including verifying this problem is now fixed) by adding the browser platform using:

cordova platform add browser@https://github.com/apache/cordova-browser --save