search

apache / cordova-browser

Apache Cordova
Apache License 2.0
170 stars 85 forks source link

fix: update shelljs to 0.8.5 #115

Closed jcesarmobile closed 1 year ago

jcesarmobile commented 1 year ago

Update the shelljs dependency to 0.8.5 as previous versions are vulnerable

There is a behavior change in shelljs that requires the project_path to exist before doing the first recursive copy or if not it will copy the content of the cordova directory instead of creating a cordova directory with all the content as 0.5.3 did. That's why there is one line addition.

closes https://github.com/apache/cordova-browser/issues/105 closes https://github.com/apache/cordova-browser/pull/108

codecov-commenter commented 1 year ago

Codecov Report

Merging #115 (4805d13) into master (2218451) will increase coverage by 0.20%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   93.54%   93.75%   +0.20%     
==========================================
  Files           2        2              
  Lines          31       32       +1     
==========================================
+ Hits           29       30       +1     
  Misses          2        2
Impacted Files Coverage Δ
bin/lib/create.js 93.33% <100.00%> (+0.22%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more