apache / cordova-browser

Apache Cordova
Apache License 2.0
168 stars 85 forks source link

refactor: @cordova/eslint-config@^5.0.0 #118

Closed breautek closed 1 year ago

breautek commented 1 year ago

Platforms affected

Browser

Motivation and Context

Upgrades eslint to our current configuration to maintain code standards.

Also upgrading also solves as a byproduct:

json5  <1.0.2
Severity: high
Prototype Pollution in JSON5 via Parse Method - https://github.com/advisories/GHSA-9c47-m6qq-7p4h

Description

Upgrade @cordova/eslint-config to 5.x and refactored necessary changes to comply with our lint rules. Fixes were made mostly via eslint --fix argument.

Testing

Ran npm test.

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #118 (6f2a39c) into master (3966de3) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files           2        2           
  Lines          32       32           
=======================================
  Hits           30       30           
  Misses          2        2           
Impacted Files Coverage Δ
bin/lib/create.js 93.33% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more