GH-122 browser: permit serving over https - Githubissues

apache / cordova-browser

Apache Cordova

Apache License 2.0

168 stars 85 forks source link

GH-122 browser: permit serving over https #123

Open mgatto opened 1 year ago

mgatto commented 1 year ago

Platforms affected

Browser

Motivation and Context

Closes #122.

Description

This PR adds a new boolean option --https which will serve the browser platform over HTTPS.

These issues is other Cordova repos are also required:

Testing

A test for cordova run browser seems not to be present in this repo (?).

Checklist

[x] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

codecov-commenter commented 1 year ago

Codecov Report

Merging #123 (857821c) into master (66d9e2e) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #123   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files           2        2           
  Lines          32       32           
=======================================
  Hits           30       30           
  Misses          2        2

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more