search

apache / cordova-browser

Apache Cordova
Apache License 2.0
170 stars 85 forks source link

CB-9669 Browser exec should have more failsafes #18

Closed purplecabbage closed 8 years ago

purplecabbage commented 8 years ago

This makes the browser exec methods consistent with other js-only platforms. CallbackID's are used, callbacks can be 'kept' and missing proxies are logged.

nikhilkh commented 8 years ago

@TimBarham - this looks like a good change to review.

purplecabbage commented 8 years ago

ping @TimBarham Can I merge this? have you had a look?

TimBarham commented 8 years ago

Sorry, yes, I looked but forgot to comment... Looks good to me! Could perhaps remove the comment referring to CB-5806 since it isn't relevant in this context, but that's no biggie.