CB-8260: (browser) Fix corrupted zip file (build) - Githubissues

apache / cordova-browser

Apache Cordova

Apache License 2.0

170 stars 85 forks source link

CB-8260: (browser) Fix corrupted zip file (build) #25

Closed VinceOPS closed 7 years ago

VinceOPS commented 7 years ago

Platforms affected

Platform "browser" only.

What does this PR do?

Replace the node module adm-zip, which is known for corrupting some files when compressing a folder to a zip archive, by the module archiver. Update the build script in order to use archiver instead of adm-zip.

What testing has been done on this change?

Making sure that all the different types of file bundled in the newly built package.zip were properly compressed, and uncompressed.

Checklist

[X] Reported an issue in the JIRA database
[X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[X] Added automated test coverage as appropriate for this change.

purplecabbage commented 7 years ago

I like this, and thank you, however, I am planning on removing zip functionality. I believe zipping was only added because someone decided that build needed some sort of output. Realistically, I think it makes more sense to let users zip their own build output as they see fit, and remove these extra deps.