CB-12905: (linux) Fix issue with freezing after launching the browser

paymicro commented 7 years ago

In Linux, the callback is not called until the process terminates. If the error is not caused within 2 seconds, then the promise will be resolved.

Platforms affected

Linux

What does this PR do?

If the error after launching the browser is not caused within 2 seconds, then the promise will be resolved.

What testing has been done on this change?

manual testing launching browsers in Linux, Windows and MacOs

Checklist

[x] Reported an issue in the JIRA database
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

matrosov-nikita commented 7 years ago

Also, I think you need to send this PR in the cordova-serve (https://github.com/apache/cordova-serve)

purplecabbage commented 7 years ago

This needs to be addressed in the cordova-serve repo if it is an issue. Closing.

gruz commented 6 years ago

@purplecabbage cordova-serve developer addresses it to you and you address to him (-: https://github.com/Microsoft/cordova-simulate/issues/245#issuecomment-310361201

@matrosov-nikita `s PR seems to work for me.

Can this be in some way fixed?

Thanks.

purplecabbage commented 6 years ago

This pr attempted to patch a dependency in the node_modules folder directly, this is not how we do things. The dependent module, cordova-serve has been patched, and released, and this module's dependent version was updated. ( https://github.com/apache/cordova-serve/pull/4 )

Not sure what else you are asking for @gruz

apache / cordova-browser