corrected path for config.xml

apache / cordova-browser

Apache Cordova

Apache License 2.0

168 stars 85 forks source link

corrected path for config.xml #50

Closed ketanyekale closed 6 years ago

ketanyekale commented 6 years ago

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

[ ] Reported an issue in the JIRA database
[ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[ ] Added automated test coverage as appropriate for this change.

janpio commented 6 years ago

What does this do? And why? Does this fix a problem?

goffioul commented 6 years ago

I had to apply the same type of change, so I guess my scenario was similar. The problems comes when you want to serve the cordova app using a non-empty URL prefix, for instance by deploying the app in apache, let's say the app is accessed using the URL http://www.example.com/myapp/index.html.

royalrex commented 6 years ago

Just found this fix.

@janpio I was having the same problem of running a cordova (ionic) web app from a subdir and it failed to load config.xml and consequently the cordova splashscreen plugin was unable to load it's config params from config.xml.

Unless there is a really good reason why it's using absolute path, I think relative path is better.

Alternatively, it should respect <base href=""> setting

stevengill commented 6 years ago

Thanks!!

ketanyekale commented 6 years ago

Thank you @stevengill