CB-13999: (browser) - Reading config.xml respects base href - Githubissues

apache / cordova-browser

Apache Cordova

Apache License 2.0

170 stars 85 forks source link

CB-13999: (browser) - Reading config.xml respects base href #60

Closed jenshelderweirdt closed 5 years ago

jenshelderweirdt commented 5 years ago

Platforms affected

Browser

What does this PR do?

Link to config.xml using the base href instead of the root (removed the trailing /)

What testing has been done on this change?

Manual testing in an Ionic/Cordova project

Checklist

[x] Reported an issue in the JIRA database
[x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
[x] ~~Added automated test coverage as appropriate for this change.~~

jcesarmobile commented 5 years ago

closing as https://github.com/apache/cordova-browser/pull/52 was merged