apache / cordova-browser

Apache Cordova
Apache License 2.0
170 stars 85 forks source link

Add Node.js 12 to CI Services #76

Closed erisu closed 4 years ago

erisu commented 5 years ago

Platforms affected

none

Motivation and Context

Add Node 12 too CI

Description

Testing

none

Checklist

erisu commented 5 years ago

@timbru31 Without quotes doesn't cause any issues, but adding them back either way is not problem.

YAML in general does not require quotation. There are exceptions for example the numbers wanted to be interpreted as string instead of a number, these should be explicitly wrapped.

Since the value is piped into the NVM terminal command, it will take the argument as a string either way.

$ nvm use 10.0.0

Here is also an example of a string value for node_js that they forgot to wrap with quotes in the doc. https://docs.travis-ci.com/user/build-environment-updates/2015-02-03/#iojs-support

For Elixir, they even talked about converting int/float values to strings only for consistency of the doc, not due to issues of the value not as a string. https://github.com/travis-ci/docs-travis-ci-com/pull/1490#issuecomment-335889711

codecov-io commented 4 years ago

Codecov Report

Merging #76 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           2        2           
  Lines          31       31           
=======================================
  Hits           29       29           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c94bce...97dc24e. Read the comment docs.