apache / cordova-browser

Apache Cordova

Apache License 2.0

168 stars 85 forks source link

Fix for issues with 'cordova run' command. #88

Closed CatchABus closed 4 years ago

CatchABus commented 5 years ago

Do not change values of args since it's used from the rest of platforms during 'cordova run' command execution which runs all platforms.

Platforms affected

Motivation and Context

87

Description

fixes #87

Testing

Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

breautek commented 5 years ago

To link this PR as a fix for another issue, you must use one of the keywords defined here.

Can you please update your PR description so that it uses one of these keywords.

E.g.

fixes

Without this, you're just simply referencing the issue, without signaling that this PR fixes that issue.

CatchABus commented 5 years ago

Done! Thanks a lot for pointing out my mistake!

codecov-io commented 4 years ago

Codecov Report

Merging #88 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           2        2           
  Lines          31       31           
=======================================
  Hits           29       29           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 10852c1...2da4616. Read the comment docs.