search

apache / cordova-browser

Apache Cordova
Apache License 2.0
168 stars 85 forks source link

breaking: @cordova/eslint-config w/ applied fix #96

Closed erisu closed 4 years ago

erisu commented 4 years ago

Motivation and Context

Use Cordova's ESLint Configs.

https://github.com/apache/cordova/issues/142

Testing

Checklist

codecov-io commented 4 years ago

Codecov Report

Merging #96 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           2        2           
  Lines          31       31           
=======================================
  Hits           29       29           
  Misses          2        2
Impacted Files Coverage Δ
bin/lib/create.js 93.10% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16271b4...973590e. Read the comment docs.

NiklasMerz commented 4 years ago

Good to merge for major release?

timbru31 commented 4 years ago

friendly ping. master is already at next major, IMHO good to merge.