apache / cordova-browser

Apache Cordova

Apache License 2.0

170 stars 85 forks source link

Inline browser_parser into Api #98

Open raphinesse opened 4 years ago

raphinesse commented 4 years ago

Motivation and Context

Reduce (unused) code.

Description

Remove unused stuff from browser_parser
Inline remaining two methods from browser_parser into Api

This removes the property parser from Api instances. AFAIK this prop is not documented, so I'd consider it private. But if we would consider it public, this PR would be a major change.

Testing

I ran npm t

codecov-commenter commented 4 years ago

Codecov Report

Merging #98 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           2        2           
  Lines          31       31           
=======================================
  Hits           29       29           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16271b4...d3d9328. Read the comment docs.