apache / cordova-cli

Apache Cordova CLI
Apache License 2.0
937 stars 337 forks source link

Plugins are not copied to platforms folders after delete repo, clone it again and build platforms #555

Open sylvestrevgen opened 3 years ago

sylvestrevgen commented 3 years ago

Bug Report

Problem

Plugins are not copied to platforms folders after delete repo, clone it again and build platforms

What is expected to happen?

Plugins is succesfully installed and worked in both platforms (Android and iOS). After delete repo locally and clone it again, plugins are successfully copied to platforms/ios and platforms/android.

What does actually happen?

After delete repo locally and clone it again, plugins are not copied to platforms folders. To fix this bug, I need to remove both platforms and add it again. After this, plugins are copied and works fine.

Information

Command or Code

Delete cordova app project, clone it again, install node modules, run cordova ios or android.

Environment, Platform, Device

iOS, Android

Version information

cordova CLI 10, cordova-android 9.1.0, cordova-ios 6.2.0

Checklist

breautek commented 3 years ago

After delete repo locally and clone it again, plugins are not copied to platforms folders. To fix this bug, I need to remove both platforms and add it again. After this, plugins are copied and works fine.

Has Cordova ever installed the platform for you before? Using cordova platform add ... for the platform you intend to buiild. This was something a requirement for as long as I remember...

sylvestrevgen commented 3 years ago

Yes, all platforms has been installed before. After delete repo and clone it again, everything is fine but plugins folder is not defined in platforms/ios and platforms/android.

sylvestrevgen commented 3 years ago

Is there anything about this bug? Or it is not a bug and we need restart platforms everytime when clone repo on another laptop?

breautek commented 3 years ago

For a team setup it's recommended to git ignore the following folders:

When you clone the repo, the developer should:

This way your project can be supported on different environments, for example you cannot work on an ios platform on windows/linux. It also makes sures that when npm install is used (behind the scenes), any native modules are installed for your specific environment.

I don't think this is a bug. Let me know what you think though. And if your flow worked before, can you give what cordova version it worked in?

sylvestrevgen commented 3 years ago

I am not sure about it worked before. I am going to try your advice. Thank you for quick answer.