search

apache / cordova-cli

Apache Cordova CLI
Apache License 2.0
940 stars 340 forks source link

chore!: Prepare for next major #642

Closed dpogue closed 5 months ago

dpogue commented 5 months ago

Platforms affected

all

Motivation and Context

We want to do a new major version which drops the telemetry stuff, this is some other cleanup that should also be included in that next major.

Description

Note that we're bumping the NodeJS engine requirement, but the lower level modules (cordova-common, cordova-lib, etc.) have not had major versions published which bump that requirement yet. However, doing the bump here means that we should be able to pull in those major versions when they do happen, provided the visible API breaking change (to cordova-cli's perspective) is the NodeJS bump.

Testing

All unit tests pass

Checklist

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.53%. Comparing base (71a5c89) to head (2d4efdf).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #642 +/- ## ======================================= Coverage 65.53% 65.53% ======================================= Files 3 3 Lines 235 235 ======================================= Hits 154 154 Misses 81 81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dpogue commented 5 months ago

I didn't have time to dig through all the outdated dependencies and see if any can be bumped. Just did the easy stuff here. I suspect things like nyc probably can be updated, and can be handled in a follow-up PR specifically for those dependencies.