apache / cordova-coho

Apache Cordova coho
Apache License 2.0
33 stars 62 forks source link

[WIP] CB-14249 ensure platform changes are in a dev version (partial workaround doc fix) #189

Open brodycj opened 6 years ago

brodycj commented 6 years ago

Platforms affected

All

What does this PR do?

Add section with note to ensure that changes are made in a "-dev" version.

This is a partial workaround for the fundamental issue in CB-14249, contributed in response to the discussion in https://github.com/apache/cordova-android/pull/469. This kind of workaround was already applied in https://github.com/apache/cordova-android/pull/470, https://github.com/apache/cordova-ios/pull/379, https://github.com/apache/cordova-android/pull/454, and several other places.

I hope we can resolve the inconsistency in release procedure for platforms vs tools described in CB-14249 someday, with agreement via dev@cordova.apache.org. I cannot promise when I will get a chance to take care of this.

TODO:

Unfortunately I think I need some of the changes from #188 to make the coho prepare-platform-release-branch command work as needed on the non-master branch. I hope I get a chance to cleanup some of the changes from #188 and fix this one in the near future.

Merge procedure

What testing has been done on this change?

Checklist

brodycj commented 6 years ago

Thanks @janpio for the feedback. I would definitely agree that the command is missing and that we should get rid of "manually". The thing is that I think we really need some of the changes I proposed in #188 for the coho command to work in the release branch. I just updated the description with this info.

There a few things I want to do first, major one is to finish the Cordova patch release before cleaning up #188. Keeping this one as "WIP" for now.