fix(versionutil): produce JS that passes our linting

apache / cordova-coho

Apache Cordova coho

Apache License 2.0

33 stars 62 forks source link

fix(versionutil): produce JS that passes our linting #253

Closed raphinesse closed 4 years ago

raphinesse commented 4 years ago

Platforms affected

All

Motivation and Context

We have recently started to try to lint as many JS files as possible. This includes the platforms' version scripts. Unfortunately coho updates them in a form that violates our code style.

Requires test updates from #250 to pass the tests

Description

Pulls out the code to update our platforms' version scripts to one location
Updates the version script according to our style guide

Testing

Passes the refactored tests from #250

erisu commented 4 years ago

Code looks fine, not sure about the test failure.

raphinesse commented 4 years ago

The test failures are because the existing unit tests are pretty bad. They basically asserted call counts for every function used in the version update module. Consequently they fail on almost any code change. That's why I posted #250.