apache / cordova-coho

Apache Cordova coho

Apache License 2.0

33 stars 62 forks source link

fix(nightly): npm install before publish for cordova-android's js build #283

Closed erisu closed 3 years ago

erisu commented 3 years ago

Motivation, Context & Description

Nightly is failing to publish Cordova-Android because of the new npm prepare-hook scrip that automates the building of the cordova-js during release.

npm i must be performed before npm publish.

Other platforms will need this change in the future once the cordova-js's new build process is added.

Testing

n/a

codecov-commenter commented 3 years ago

Codecov Report

Merging #283 (a24d3c0) into master (fd93ade) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #283   +/-   ##
=======================================
  Coverage   58.73%   58.73%           
=======================================
  Files           8        8           
  Lines         492      492           
=======================================
  Hits          289      289           
  Misses        203      203

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd93ade...a24d3c0. Read the comment docs.