apache / cordova-coho

Apache Cordova coho
Apache License 2.0
33 stars 62 forks source link

fix: Ignore codecov files #307

Closed breautek closed 1 year ago

breautek commented 1 year ago

Ignores coverage/ files

I opted to not use coverage as the exclude term, as I felt that's too generic/broad and may potentially exclude files that we would want to scan.

The RAT tool also doesn't appear to support a full glob syntax, so doing something like coverage/** doesn't work.

So finally I choose lcov-* and lcov.info, which I feel is the safest exclude terms.

These are generated files by code coverage tools and RAT states:

Generated files do not require license headers.

Yet these files were being checked and was creating unnecessary noise.

codecov-commenter commented 1 year ago

Codecov Report

Merging #307 (faa70b9) into master (117f293) will increase coverage by 1.82%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #307      +/-   ##
==========================================
+ Coverage   56.91%   58.73%   +1.82%     
==========================================
  Files           8        8              
  Lines         492      492              
==========================================
+ Hits          280      289       +9     
+ Misses        212      203       -9     
Impacted Files Coverage Δ
src/audit-license-headers.js 78.26% <ø> (ø)

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more