search

apache / cordova-coho

Apache Cordova coho
Apache License 2.0
33 stars 62 forks source link

[CB-7744] Add support for git-depth flag to coho clone #52

Closed MariaBukharina closed 10 years ago

MariaBukharina commented 10 years ago

Add support for git-depth flag to coho clone to be able to check out only latest version and reduce check out time

sgrebnov commented 10 years ago

Does anyone know why this PR was closed w/o any comment? I personally think that this option is very valuable, for example to significantly speed up Medic which uses coho to check out platforms and plugins.

agrieve commented 10 years ago

I don't see any commit logs that tell it close it, and I don't see it merged either. Change LGTM as well. Maybe just pull it in now even though it's closed?

purplecabbage commented 10 years ago

We should stop closing issues from other repositories, since @asfgit closing it does not give us any more info. Looking at cordova-coho and elsewhere, I still see no mention of 52, so this one is a mystery. Here is a 'multi repo close issues' commit message:

close apache/cordova-lib#94
close #39
close apache/cordova-android#120
close apache/cordova-android#123

At least a practice of only closing from the repo with the pull request would make this a bit easier to track down. Magic is powerful, use it wisely.

sgrebnov commented 10 years ago

@agrieve, @purplecabbage thx for looking on this! I've asked @MariaBukharina to send PR one more time w/o 'd' alias for '--depth' arg since we use -d for debug in other places.