search

apache / cordova-coho

Apache Cordova coho
Apache License 2.0
33 stars 62 forks source link

[CB-5258] use exit library #7

Closed jsoref closed 10 years ago

jsoref commented 10 years ago

On Windows, if you have pending bits in pipes and you exit, they generally do not get delivered.

To avoid this, you need to change process.exit() to something which actually ensures that buffers are flushed before it exits, this is handled by the 'exit' module/function.

agrieve commented 10 years ago

Sorry for not seeing this a month ago.

Patch no longer applies cleanly, could you fix it up?

Not sure it's necessary though. Coho does all its IO synchronously, so I don't see when there's be anything in progress when exit is called. Does this fix something, or is it just theoretical?

jsoref commented 10 years ago

IO isn't actually synchronous.  

‎When I do coho repo-status, I often lose lines of output on OS X‎ (although it's typically not the last line) .

I can rebase...‎

This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

jsoref commented 10 years ago

err, no, bad merge.