search

apache / cordova-coho

Apache Cordova coho
Apache License 2.0
33 stars 62 forks source link

Initial coho handling for the new cordova-serve module in cordova-lib. #84

Closed TimBarham closed 9 years ago

TimBarham commented 9 years ago
  1. Adds cordova-serve as another "repo" in coho's list of repos (it actually just points to the cordova-lib repo, but allows various command to work directly on cordova-serve).
  2. Adds the ability to work with prefixed tags, so cordova-serve can maintain versions independent of cordova-lib.

Note that this introduces cordova-serve as another "repo" as far as coho is concerned, which I think works ok for now. But ultimately, particularly if we introduce more modules in the cordova-lib repo, we should probably add to coho the concept of "modules" or "packages" within repos (so cordova-serve would not exist as a separate "repo" in coho's list of repos, but as a module within the cordova-lib repo, alongside the cordova-lib module) - then, among other benefits, we can provide generic handling for the fact that modules live within sub-directories of their repo (rather than the custom handling we have now).

stevengill commented 9 years ago

Haven't tested this yet, but first question that comes to mind is how would this affect repo-clone?

TimBarham commented 9 years ago

Ah, good question. I'll try it out. I tried a few scenarios, and was trying to think of one where having two items in the repo list pointing to the same repo could cause a problem - that might be a good example. If it causes a problem, I might have to move to the model where we support defining "modules" within a repo (wanted to avoid that for now because it will be a bunch more work).

TimBarham commented 9 years ago

Ok, I'm gonna close this an open a new PR with a much more complete change.