search

apache / cordova-coho

Apache Cordova coho
Apache License 2.0
33 stars 62 forks source link

CB-9361 Make verify-tags working nicely with Windows command prompt. #91

Closed TimBarham closed 9 years ago

TimBarham commented 9 years ago

The verify-tags command currently relies on users hitting Ctrl+D to trigger the end of input. However, this doesn't work in the Windows command prompt.

I've modified this to use Node's readline module - read the input line by line, then process when an empty line is encountered. This way, the tags can be pasted then simply press Enter. On Unix-like systems, Ctrl+D will continue to work (and if you pipe in a file that will still work), since the EOF will trigger the close event.

dblotsky commented 9 years ago

Tried pasting manually as well as piping on bash and cmd on Windows, and on bash on OSX; all work fine. LGTM!