apache / cordova-common

Apache Cordova Common Tooling Library

https://cordova.apache.org/

Apache License 2.0

39 stars 40 forks source link

ci: Remove Node 10/12 from matrix. Added Node 16 and 18. #180

Closed breautek closed 2 years ago

breautek commented 2 years ago

Platforms affected

CI

Motivation and Context

Node 10/12 is now dated and EOL, therefore they have been removed from the matrix. Added Node 16 & 18 for modern test coverage.

Also appears to correct:

{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

Which appears to occur on older Node engines.

Description

CI Matrix change

Testing

GH Actions will do it's thing.

Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

codecov-commenter commented 2 years ago

Codecov Report

Merging #180 (b023bad) into master (4d8475d) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   87.79%   87.79%           
=======================================
  Files          20       20           
  Lines        1131     1131           
=======================================
  Hits          993      993           
  Misses        138      138

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more