apache / cordova-common

Apache Cordova Common Tooling Library
https://cordova.apache.org/
Apache License 2.0
39 stars 40 forks source link

dep: replace underscore w/ lodash module pkgs #193

Closed erisu closed 1 year ago

erisu commented 1 year ago

Motivation and Context

Drop the entire underscore package.

Description

Only a few methods from the package was being used. To reduce the size footprint, I replaced with various lodash modules.

Testing

Checklist

codecov-commenter commented 1 year ago

Codecov Report

Merging #193 (cfefcd3) into master (b782a72) will increase coverage by 0.03%. The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   88.43%   88.46%   +0.03%     
==========================================
  Files          20       20              
  Lines        1141     1144       +3     
==========================================
+ Hits         1009     1012       +3     
  Misses        132      132              
Impacted Files Coverage Δ
src/superspawn.js 85.24% <50.00%> (ø)
src/util/plist-helpers.js 76.92% <100.00%> (+1.24%) :arrow_up:
src/util/xml-helpers.js 99.01% <100.00%> (+<0.01%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more