liyamahendra commented 1 year ago

Platforms affected

android

Motivation and Context

Android 13 added support for Themed Icons. Since themed icons aren't yet supported on Cordova Android, adding support for Themed icons inside cordova-android required modification to this project as the former project uses getStaticResources function defined inside cordova-common

https://github.com/apache/cordova-android/issues/1450

Description

Added support for parsing the monochrome icon for Android when preparing / updating the icons.

Testing

Checklist

[x] I've run the tests to see all new and existing tests pass
[x] I added automated test coverage as appropriate for this change
[x] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[x] I've updated the documentation if necessary

codecov-commenter commented 1 year ago

Codecov Report

Merging #197 (8f415cf) into master (cc78c81) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
+ Coverage   88.38%   88.39%   +0.01%     
==========================================
  Files          20       20              
  Lines        1145     1146       +1     
==========================================
+ Hits         1012     1013       +1     
  Misses        133      133

Impacted Files	Coverage Δ
src/ConfigParser/ConfigParser.js	`85.45% <100.00%> (+0.08%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

erisu commented 1 year ago

Why was this PR closed?