erisu commented 1 year ago

Platforms affected

n/a

Motivation and Context

use latest npm glob dependency.

Description

bump glob to 9.0.1
updated code to use glob.globSync, not glob.sync.

Testing

npm t

Checklist

[x] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

codecov-commenter commented 1 year ago

Codecov Report

Merging #199 (e2f25fa) into master (ecad4db) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   88.37%   88.37%           
=======================================
  Files          20       20           
  Lines        1144     1144           
=======================================
  Hits         1011     1011           
  Misses        133      133

Impacted Files	Coverage Δ
src/ConfigChanges/ConfigFile.js	`92.23% <100.00%> (ø)`
src/PluginInfo/PluginInfoProvider.js	`79.31% <100.00%> (ø)`
src/superspawn.js	`85.24% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

erisu commented 1 year ago

Unable to reproduce the failing tests on my Windows 10 Pro environment.

I changed the status of this PR to draft and set its milestone for 6.0.0. More investigation is required.

apache / cordova-common

[RFC] dep!: bump glob@9.0.1 w/ package-lock.v3 rebuilt #199