apache / cordova-common

Apache Cordova Common Tooling Library
https://cordova.apache.org/
Apache License 2.0
39 stars 40 forks source link

chore(deps): Modernize some dependencies #203

Closed dpogue closed 8 months ago

dpogue commented 8 months ago

Platforms affected

All

Motivation and Context

Bring some dependencies up to date and remove some dependencies that aren't needed with modern NodeJS APIs.

closes #199

Description

Testing

Unit tests pass.

Checklist

codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 95.91837% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.40%. Comparing base (dd3eca8) to head (bc5f84f). Report is 1 commits behind head on master.

Files Patch % Lines
src/ConfigParser/ConfigParser.js 50.00% 1 Missing :warning:
src/superspawn.js 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #203 +/- ## ========================================== + Coverage 88.37% 88.40% +0.03% ========================================== Files 20 20 Lines 1144 1147 +3 ========================================== + Hits 1011 1014 +3 Misses 133 133 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

erisu commented 8 months ago

Might want to rebuild the package-lock.json file once.

It appears the following packages are still listed in the lock file:

    "fs-extra": "^11.1.0",
    "glob": "^7.1.6",
dpogue commented 8 months ago

Might want to rebuild the package-lock.json file once.

Oops, good catch. I've regenerated package-lock.json