apache / cordova-electron

Apache Cordova Electron
Apache License 2.0
126 stars 59 forks source link

Cordova flag --buildConfig does not seem to work #159

Open rohitagre opened 4 years ago

rohitagre commented 4 years ago

Bug Report

Problem

cordova build command does not accept --buildConfig flag for electron

    --buildConfig....................... Use the specified build configuration
                                         instead of default build.json

https://cordova.apache.org/docs/en/latest/reference/cordova-cli/#cordova-build-command

What is expected to happen?

The configuration must be loaded from the given config file.

What does actually happen?

user@pc ~ % cordova build electron --buildConfig=buildConfig.json  --release 
Cannot find module 'buildConfig.json'

Information

Command or Code

Create a file named buildConfig.json and put all build flags in that file, remove build.json if any. Run the following commands

cordova platform add electron@nightly
cordova build electron --buildConfig=buildConfig.json  --release 

Environment, Platform, Device

Environment : MacOS Platform : Cordova Electron building for Mac and windows on Mac

Version information

OS : MacOS 10.15.5 Cordova : 9.0.0 (cordova-lib@9.0.1) Cordova-electron : nightly build

Checklist

erisu commented 4 years ago

@jammer99

The current workaround solution is either:

  1. Provide the full file path to the build configuration json. E.g. /path/to/buildConfig.json
  2. Rename the file too build.json and do not set the --buildConfig.

I believe I see what might be happening and will fix it later today.