Closed erisu closed 1 year ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 91.66%. Comparing base (
23be9ed
) to head (584f007
). Report is 15 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Platforms affected
n/a
Motivation and Context
Remove rewire which causes issues in Jasmine testing when files contains
#!
The issue will appear when rebuilding
package-lock.json
or bumping@npmcli/arborist
.Since
rewire
has not been updated in a long time, it is better to remove.Description
Removed the unit test file that focused on testing private internal methods. These methods are called and covered by calling the install and uninstall tests.
Only 1.56% is lost from coverage but the single line it covered was only if an argument existed on an array.
This could be easily restored by adding more install tests with the flag. Only downside is increased run time as it calls npm and git directly.
Testing
npm t
With the unit testing of the private inner methods.
With out the unit testing of the private inner methods.
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)