apache / cordova-fetch

Apache Cordova Fetch Library
https://cordova.apache.org/
Apache License 2.0
27 stars 27 forks source link

package.json fix eslint script to be more explicit #32

Closed brodycj closed 6 years ago

brodycj commented 6 years ago

needed to avoid running eslint on external node_modules as installed by npm install

raphinesse commented 6 years ago

Which external node_modules?

brodycj commented 6 years ago

reworded

raphinesse commented 6 years ago

I committed the current configuration and made sure that node_modules were not checked when I did so. The docs say:

In addition to any patterns in a .eslintignore file, ESLint always ignores files in /node_modules/* and /bower_components/*.

So the change in this PR should not be necessary.

raphinesse commented 6 years ago

@brodybits did it work for you as is?

brodycj commented 6 years ago

Haven't seen a problem yet. This looks like a case of imagined problems:)