Closed brodycj closed 6 years ago
@raphinesse I just rebased with the stray changes in 30d05ba taken out, would like to merge (as a merge commit) once Travis goes green.
Can't seem to change my review to approval now that the branch is merged. But I approve :+1:
Changes
master
:spec/support/dummy-local-plugin/plugin.xml
(copied from cordova-plugin-device)master
:npm i --save-dev fs-extra@4
- quick fix needed for [GH-23] shelljs -> fs-extra in spec only (1.3.x)Motivation & rationale:
master
branch which now targets next major release is not desiredSome updates not (yet) included from
master
:spec/fetch-unit.spec.js
) - GH-17spec/fetch.spec.js
&spec/helpers.js
but not tospec/fetch-unit.spec.js
,index.js
orpackage.json
are cherry-picked in this PR)Testing
npm audit
shows 0 vulnerabilities (npm@6.3.0)npm outdated --depth=0
shows no red entriescoho audit-license-headers -r fetch
shows no missing license headerscoho check-license -r fetch
shows no incorrect licenses (manually verified thatxmldom
has acceptable MIT license option)npm test
& other tasks succeed on AppVeyor CInpm test
& other tasks succeed on Travis CI