apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 986 forks source link

Fix BackgroundColor parsing for lowercase letters #1005

Closed dpogue closed 3 years ago

dpogue commented 3 years ago

Platforms affected

iOS

Motivation and Context

The guy who implemented this background colour parsing code forgot that lowercase letters existed when writing the regex 🙄 (aka, me)

Description

Adds support for lowercase hex characters in BackgroundColor preference parsing, along with appropriate tests.

Testing

Added additional test cases with lowercase characters.

Checklist

codecov-io commented 3 years ago

Codecov Report

Merging #1005 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1005   +/-   ##
=======================================
  Coverage   74.91%   74.91%           
=======================================
  Files          13       13           
  Lines        1718     1718           
=======================================
  Hits         1287     1287           
  Misses        431      431           
Impacted Files Coverage Δ
bin/templates/scripts/cordova/lib/prepare.js 85.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b785d9...363b8d5. Read the comment docs.