search

apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.16k stars 989 forks source link

Remove placeholder icons from Images.xcassets #1019

Closed calrsom closed 1 month ago

calrsom commented 3 years ago

Feature Request

Motivation Behind Feature

Our app was rejected from the app store because it included placeholder Cordova app icons. I have to remove Cordova icons for sizes I don't provide by hand from the Xcode project.

Feature Description

I'd like Cordova to not include or delete all placeholder icons from the Images.xcassets as long as at least one <icon /> is defined in config.xml. This gives developers direct control over which icon sizes are included in their application.

As a bonus this covers the more specific feature request #658 to avoid supplying watch icons.

Alternatives or Workarounds

Currently, the only workaround is to include every single possible size icon in order to overwrite all placeholders. This is excessive and unnecessary. Our app only targets iPad and iOS 11+, so I'd prefer not to have to include icons for iPhone, Apple Watch, and iOS 5 & 6.

I was hoping setting <icon /> without height and width would generate icons for appropriate sizes, but instead it does not resize the source image at all, generating warnings in Xcode.

calrsom commented 1 month ago

I've moved on from the project I worked on that used Cordova, but I'm glad to hear this is implemented. 🎉 Thanks!