apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 988 forks source link

fix: plugin podspec with no config elements #1067

Closed erisu closed 3 years ago

erisu commented 3 years ago

Motivation and Context

Fail to install plugins with missing podspec config elements.

fixes #913

Description

Add conditional checks.

Testing

Checklist

codecov-io commented 3 years ago

Codecov Report

Merging #1067 (80418c5) into master (fb5fd2f) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1067      +/-   ##
==========================================
+ Coverage   74.84%   74.88%   +0.04%     
==========================================
  Files          13       13              
  Lines        1721     1724       +3     
==========================================
+ Hits         1288     1291       +3     
  Misses        433      433              
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 71.83% <100.00%> (+0.30%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb5fd2f...80418c5. Read the comment docs.

brodybits commented 3 years ago

Thanks for fixing!