Closed NiklasMerz closed 3 years ago
Merging #1069 (1df6063) into master (e1cc096) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #1069 +/- ##
=======================================
Coverage 74.88% 74.88%
=======================================
Files 13 13
Lines 1724 1724
=======================================
Hits 1291 1291
Misses 433 433
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e1cc096...1df6063. Read the comment docs.
Thanks @breautek for the summary.
Regarding nopt
: Seems like they just did a small dependency update: https://github.com/npm/nopt/compare/v4.0.3...v5.0.0
In the comment you say wanted 4.0.3 but updated to 5.0.0. Also says “minor and patch” but that’s major.
Not saying we shouldn’t update to 5.0.0, only that the description is confusing.
NPM outdated wanted 4.0.3. Since I did not find dangerous changes in 5.0.0 (see previous comment) I updated to the latest version.
5.0.0 looks save but I can revert that.
Just saying that the PR change doesn’t do what you say it does in the or description, you can just update the description
Thank you all for the feedback
Platforms affected
iOS
Motivation and Context
Working through the release process I found some outdated dependencies:
Description
I updated dependencies and found no issues locking at the release notes and test results. They should fit in this minor release.
Some packages turned tests red and are major upgrades. I created an issue for the next version: https://github.com/apache/cordova-ios/issues/1068
Testing
Tests and CI
Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)