Open ath0mas opened 3 years ago
:exclamation: No coverage uploaded for pull request base (
master@a3a3936
). Click here to learn what that means. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #1100 +/- ##
=========================================
Coverage ? 74.88%
=========================================
Files ? 13
Lines ? 1724
Branches ? 0
=========================================
Hits ? 1291
Misses ? 433
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
bin/templates/scripts/cordova/lib/Podfile.js | 73.20% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a3a3936...84a2eea. Read the comment docs.
Platforms affected
iOS
Motivation and Context
Mixed default values for
create
between cli doc, cordova-android and cordova-ios.Description
Package ids were mostly correct but not all, and same for project name. Suggested proper defaults:
io.cordova.helloCordova
Hello Cordova
See linked PRs: apache/cordova-cli#554, apache/cordova-android#1213
And
createProject
on how to init and deal with its parametersfs.ensureDirSync
is used~(see each commit for detail on my steps)
Testing
npm test
successChecklist
(platform)
if this change only applies to one platform (e.g.(android)
)