apache / cordova-ios

Apache Cordova iOS
https://cordova.apache.org/
Apache License 2.0
2.15k stars 987 forks source link

fix(ios): split xcode project location by env separator #1140

Closed SvyatoslavPozhydaev closed 2 years ago

SvyatoslavPozhydaev commented 2 years ago

Platforms affected

ios

Motivation and Context

fixes https://github.com/apache/cordova-ios/issues/1139

Description

replaced the delimiter string with the environment delimiter

Testing

I've tested this code on install cordova plugin like scandit-cordova-datacapture-core

Checklist

breautek commented 2 years ago

Closing/reopening cause idk why checks didn't run.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1140 (a6762d0) into master (7a4f7c3) will not change coverage. The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1140   +/-   ##
=======================================
  Coverage   74.86%   74.86%           
=======================================
  Files          13       13           
  Lines        1723     1723           
=======================================
  Hits         1290     1290           
  Misses        433      433           
Impacted Files Coverage Δ
bin/templates/scripts/cordova/Api.js 71.83% <75.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a4f7c3...a6762d0. Read the comment docs.

breautek commented 2 years ago

Thanks for the reviews and thank you @SvyatoslavPozhydaev for your effort into preparing this PR.