apache / cordova-ios

Apache Cordova iOS

https://cordova.apache.org/

Apache License 2.0

2.16k stars 989 forks source link

chore!: Breaking API cleanups #1161

Closed dpogue closed 2 years ago

dpogue commented 2 years ago

Platforms affected

iOS

Motivation and Context

Breaking API changes for v7.0.0

Description

Removes deprecated colorFromColorString API from CDVViewController
Makes CDVCommandDelegateImpl private API since it's an implementation detail

Testing

Unit tests pass

codecov-commenter commented 2 years ago

Codecov Report

Merging #1161 (d5d8772) into master (92e6830) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1161   +/-   ##
=======================================
  Coverage   74.86%   74.86%           
=======================================
  Files          13       13           
  Lines        1723     1723           
=======================================
  Hits         1290     1290           
  Misses        433      433

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92e6830...d5d8772. Read the comment docs.