NiklasMerz commented 2 years ago

Platforms affected

iOS

Motivation and Context

Building an iOS app for Mac fails with our current copy script. #1158 tries to solve this with a Xcode build step instead of a custom shell script.

This is an alternative solution proposed by @pulpgrinder with a simple condition in the current script. This is probably bettter for backwards compatibility.

Addresses issue: #699

Description

If the target platform is Mac Catalyst the correct paths are used.

Testing

Run app for:

Mac
Mac Rosseta
Mac iPad
iOS simulator

Checklist

[ ] I've run the tests to see all new and existing tests pass
[ ] I added automated test coverage as appropriate for this change
[ ] Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
[ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
[ ] I've updated the documentation if necessary

codecov-commenter commented 2 years ago

Codecov Report

Merging #1165 (98d2a6b) into master (92e6830) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1165   +/-   ##
=======================================
  Coverage   74.86%   74.86%           
=======================================
  Files          13       13           
  Lines        1723     1723           
=======================================
  Hits         1290     1290           
  Misses        433      433

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 92e6830...98d2a6b. Read the comment docs.

dpogue commented 2 years ago

Closing this in favour of #1158, which has been merged.

apache / cordova-ios

adjust build script for run on mac #1165